-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix getting-started.md with the correct import packages in main.go #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangn2
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
October 18, 2022 03:16
|
fangn2
force-pushed
the
getting-started-doc-fix
branch
from
October 18, 2022 03:17
fcc5451
to
aae5e07
Compare
fangn2
force-pushed
the
getting-started-doc-fix
branch
from
October 18, 2022 03:29
aae5e07
to
16d6c19
Compare
hanyuancheung
approved these changes
Oct 18, 2022
dmathieu
reviewed
Oct 18, 2022
pellared
approved these changes
Oct 18, 2022
@fangn2 Thanks for the PR ❤️ |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3354 +/- ##
=======================================
- Coverage 77.8% 77.8% -0.1%
=======================================
Files 164 164
Lines 11278 11264 -14
=======================================
- Hits 8778 8765 -13
+ Misses 2303 2301 -2
- Partials 197 198 +1
|
dmathieu
approved these changes
Oct 18, 2022
MrAlias
approved these changes
Oct 18, 2022
dashpole
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Provides helpful information
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixs the import packages section of main.go in getting-started.md which is not synced with the source code.
Following current getting-started guide as it misses few packages in the import, it will result in error.
Check error message as blow:
dev-dsk-nhfang % go run .
# fib
./main.go:27:21: undefined: resource
./main.go:28:10: undefined: resource
./main.go:29:3: undefined: resource
./main.go:30:3: undefined: resource
./main.go:34:4: undefined: attribute
./main.go:67:2: undefined: signal